hexops/mach

harfbuzz: Position definition is named incorrectly, needs clarification var field is private/internal #1046

New issue

Closed

opened 2023-10-02 16:48:34 +00:00 by emidoots · 0 comments

emidoots commented

2023-10-02 16:48:34 +00:00

(Migrated from github.com)

github.com/hexops/mach-freetype@92773615e2/src/harfbuzz.zig (L273-L279)

The type should be named GlyphPosition not Position

https://harfbuzz.github.io/harfbuzz-hb-buffer.html#hb-glyph-position-t

(EDIT: it having a var field is correct, it's a private field and we should add docs clarifying that.)

https://github.com/hexops/mach-freetype/blob/92773615e2480c0a6f561748f2ba1180376bbb68/src/harfbuzz.zig#L273-L279 The type should be named `GlyphPosition` not `Position` https://harfbuzz.github.io/harfbuzz-hb-buffer.html#hb-glyph-position-t (EDIT: it having a var field is correct, [it's a private field](https://sourcegraph.com/github.com/hexops/harfbuzz@18cdecff3956b8f524a28ea2392ab4b4d5e3b7e3/-/blob/src/hb-buffer.h?L191-199) and we should add docs clarifying that.)

Sign in to join this conversation.

No labels

contributor-friendly

direct3d-headers

driver-os-issue

linux-audio-headers

package-manager

proposal-accepted

vulkan-zig-generated

wayland-headers

xcode-frameworks

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

hexops/mach#1046

No description provided.