Dusk: Support parentheses expressions #1090

New issue

Closed

opened 2023-10-27 21:10:35 +00:00 by clickingbuttons · 2 comments

clickingbuttons commented

2023-10-27 21:10:35 +00:00

(Migrated from github.com)

Pretty simple to add to parser.

 fn expectParenExpr(p: *Parser) !NodeIndex {
-    _ = try p.expectToken(.paren_left);
+    const main_token = try p.expectToken(.paren_left);
     const expr = try p.expression() orelse {
         try p.errors.add(
             p.peekToken(.loc, 0),
@@ -1491,7 +1491,11 @@ fn expectParenExpr(p: *Parser) !NodeIndex {
         return error.Parsing;
     };
     _ = try p.expectToken(.paren_right);
-    return expr;
+    return try p.addNode(.{
+        .tag = .paren_expr,
+        .main_token = main_token,
+        .lhs = expr,
+    });
 }

Pretty simple to add to parser. ```diff fn expectParenExpr(p: *Parser) !NodeIndex { - _ = try p.expectToken(.paren_left); + const main_token = try p.expectToken(.paren_left); const expr = try p.expression() orelse { try p.errors.add( p.peekToken(.loc, 0), @@ -1491,7 +1491,11 @@ fn expectParenExpr(p: *Parser) !NodeIndex { return error.Parsing; }; _ = try p.expectToken(.paren_right); - return expr; + return try p.addNode(.{ + .tag = .paren_expr, + .main_token = main_token, + .lhs = expr, + }); } ```

Rows
Columns