glfw: Pull request #136 overwrites #72 #149

Closed
opened 2021-12-28 08:51:23 +00:00 by nilhiu · 4 comments
nilhiu commented 2021-12-28 08:51:23 +00:00 (Migrated from github.com)

GLFW has yet to merge this pull request and the version bump from #136 has overwritten #72 (x11_window.c line 1286).

GLFW has yet to merge [this pull request](https://github.com/glfw/glfw/pull/1989) and the version bump from #136 has overwritten #72 (`x11_window.c` line 1286).
iddev5 commented 2021-12-28 09:42:41 +00:00 (Migrated from github.com)

If it is not merged to upstream soon, then I think it would make sense to have a solution in the form of a patch which gets auto merged with update-upstream.sh

If it is not merged to upstream soon, then I think it would make sense to have a solution in the form of a patch which gets auto merged with ``update-upstream.sh``
alichraghi commented 2021-12-28 09:55:02 +00:00 (Migrated from github.com)

or maybe add a note to README.
i think at least someone remember this when we are updating glfw

or maybe add a note to README. i think at least someone remember this when we are updating glfw
iddev5 commented 2021-12-28 10:20:21 +00:00 (Migrated from github.com)

Maintainer info should not be added to README.md which is meant for end users

Anyways we can discuss this further in #95

Maintainer info should not be added to README.md which is meant for end users Anyways we can discuss this further in #95
emidoots commented 2021-12-28 11:00:56 +00:00 (Migrated from github.com)

@hasklix Merged the fix, thanks for reporting this!

Let's continue discussion of how to prevent this from regressing in the future in #95

@hasklix Merged the fix, thanks for reporting this! Let's continue discussion of how to prevent this from regressing in the future in #95
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach#149
No description provided.