glfw: ensure git present #316

Merged

d3m1gd merged 3 commits from check-git into main

2022-05-30 17:24:09 +00:00

d3m1gd commented

2022-05-29 05:28:35 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

- [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

iddev5 (Migrated from github.com) reviewed

2022-05-29 06:11:56 +00:00

iddev5 (Migrated from github.com) left a comment

Top level build.zig also needs this check as it contains ensureSubmodule()

d3m1gd commented

2022-05-29 06:35:15 +00:00

(Migrated from github.com)

it might not be needed there, as glfw will be called anyway, and missing git will be discovered

iddev5 commented

2022-05-29 09:12:40 +00:00

(Migrated from github.com)

That won't work. Non-native (wasm) builds don't call glfw.link().

iddev5 (Migrated from github.com) reviewed

2022-05-29 10:28:58 +00:00

build.zig

I think this should be rather put here: github.com/hexops/mach@0dabe0d49f/build.zig (L26)
There's no need to call this function everytime you invoke git

I think this should be rather put here: https://github.com/hexops/mach/blob/0dabe0d49fa621ed43dc2ba092f56e54d4b117b3/build.zig#L26 There's no need to call this function everytime you invoke git

iddev5 (Migrated from github.com) reviewed

2022-05-29 10:31:41 +00:00

glfw/system_sdk.zig

And this should be placed here: github.com/hexops/mach@f0f91874da/glfw/system_sdk.zig (L204) as both the code paths use git

And this should be placed here: https://github.com/hexops/mach/blob/f0f91874da865d43eabb751905dd8e0f9026f09e/glfw/system_sdk.zig#L204 as both the code paths use git