glfw: undefined behavior caught by UBSan with wayland glfwGetKeyName #375

New issue

Closed

opened 2022-06-28 18:00:08 +00:00 by emidoots · 1 comment

emidoots commented

2022-06-28 18:00:08 +00:00

(Migrated from github.com)

After https://github.com/hexops/mach/pull/374 we disabled a test because:

Segmentation fault at address 0x80
???:?:?: 0x7f683544b9c4 in ??? (???)
upstream/glfw/src/input.c:713:12: 0x30a0a7 in glfwGetKeyName (/home/Zargio/Documents/Github/mach/glfw/src/sources_all.c)
    return _glfw.platform.getScancodeName(scancode);
           ^
/home/Zargio/Documents/Github/mach/glfw/src/key.zig:220:43: 0x248115 in key.test "getName" (test)
        const name_opt = cc.glfwGetKeyName(@enumToInt(self), @intCast(c_int, scancode));

After https://github.com/hexops/mach/pull/374 we disabled a test because: ``` Segmentation fault at address 0x80 ???:?:?: 0x7f683544b9c4 in ??? (???) upstream/glfw/src/input.c:713:12: 0x30a0a7 in glfwGetKeyName (/home/Zargio/Documents/Github/mach/glfw/src/sources_all.c) return _glfw.platform.getScancodeName(scancode); ^ /home/Zargio/Documents/Github/mach/glfw/src/key.zig:220:43: 0x248115 in key.test "getName" (test) const name_opt = cc.glfwGetKeyName(@enumToInt(self), @intCast(c_int, scancode)); ```

Rows
Columns