CI: Improve jobs #395

Closed
opened 2022-07-08 14:37:39 +00:00 by alichraghi · 2 comments
alichraghi commented 2022-07-08 14:37:39 +00:00 (Migrated from github.com)

Some CI jobs aren't necessary and can be safely removed.
my claims on last 20 workflow runs:

  • Sub-projects steps can be runned in the main job
  • Cross-compiling in all three platform doesn't make sense anymore. Linux is also faster at cross-compiling (2x faster than windows and 1-2x compared to macOS)
  • Windows and macOS jobs can just run zig build and zig build test
Some CI jobs aren't necessary and can be safely removed. my claims on last 20 workflow runs: - Sub-projects steps can be runned in the main job - Cross-compiling in all three platform doesn't make sense anymore. Linux is also faster at cross-compiling (2x faster than windows and 1-2x compared to macOS) - Windows and macOS jobs can just run `zig build` and `zig build test`
emidoots commented 2022-07-09 22:17:54 +00:00 (Migrated from github.com)

Sub-projects steps can be runned in the main job

Can you clarify what you mean with this?

Cross-compiling in all three platform doesn't make sense anymore
Windows and macOS jobs

Agreed.

> Sub-projects steps can be runned in the main job Can you clarify what you mean with this? > Cross-compiling in all three platform doesn't make sense anymore > Windows and macOS jobs Agreed.
alichraghi commented 2022-07-10 07:48:49 +00:00 (Migrated from github.com)

Can you clarify what you mean with this?

running zig build test in each sub-project in the main jobs (x86_64-linux (.), x86_64-windows (.), x86_64-macos (.)). so they will be an step instead of a job.
atm i think CI must be categorized with machine specs not sub-projects. this saves the time wasted on zig setup.
i also found this https://github.community/t/is-it-possible-to-run-the-job-only-when-a-specific-file-changes/115484/2. so we can skip testing unchanged sub-projects

> Can you clarify what you mean with this? running `zig build test` in each sub-project in the main jobs (`x86_64-linux (.)`, `x86_64-windows (.)`, `x86_64-macos (.)`). so they will be an step instead of a job. atm i think CI must be categorized with machine specs not sub-projects. this saves the time wasted on zig setup. i also found this https://github.community/t/is-it-possible-to-run-the-job-only-when-a-specific-file-changes/115484/2. so we can skip testing unchanged sub-projects
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach#395
No description provided.