hexops/mach
1
0
Fork 0
Code Issues 152 Pull requests 18 Releases Activity Actions 3

freetype/harfbuzz: getGlyphInfos() returns incorrect values #415

New issue
Closed
opened 2022-07-18 04:06:39 +00:00 by ghost · 6 comments
ghost commented 2022-07-18 04:06:39 +00:00 (Migrated from github.com)
Copy link

When using harfbuzz with freetype, getGlyphInfos() returns incorrect values compared to using hb_buffer_get_glyph_infos() directly.
Here's code using Arabic text with Amiri-Regular font, but the problem happens in English and other fonts too.
The output of the program is

using getGlyphInfos()
.harfbuzz.buffer.GlyphInfo{ .codepoint = 65, .cluster = 2147484224 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 10, .cluster = 2 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 7, .cluster = 1620 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 2147484179, .cluster = 8 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 18, .cluster = 16777223 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 1729, .cluster = 2147484291 }
using c.hb_buffer_get_glyph_infos()
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 }
When using harfbuzz with freetype, getGlyphInfos() returns incorrect values compared to using hb_buffer_get_glyph_infos() directly. Here's [code](https://gist.github.com/AB55AL/520d50dd05c8b72665a2efa6844cd341) using Arabic text with Amiri-Regular font, but the problem happens in English and other fonts too. The output of the program is ``` using getGlyphInfos() .harfbuzz.buffer.GlyphInfo{ .codepoint = 65, .cluster = 2147484224 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 10, .cluster = 2 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 7, .cluster = 1620 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 2147484179, .cluster = 8 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 18, .cluster = 16777223 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 1729, .cluster = 2147484291 } using c.hb_buffer_get_glyph_infos() .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f397c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7fff686f3980 } ```
alichraghi commented 2022-07-18 05:41:29 +00:00 (Migrated from github.com)
Copy link

optionally, could you compare output without binding?

optionally, could you compare output without binding?
ghost commented 2022-07-18 06:39:14 +00:00 (Migrated from github.com)
Copy link

Sure. It looks to be the same.

using bindings of both freetype and harfbuzz
.harfbuzz.buffer.GlyphInfo{ .codepoint = 65, .cluster = 2147484224 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 10, .cluster = 2 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 7, .cluster = 1620 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 2147484179, .cluster = 8 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 18, .cluster = 16777223 }
.harfbuzz.buffer.GlyphInfo{ .codepoint = 1729, .cluster = 2147484291 }
------------------------------
freetype and harfbuzz without bindings
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 }
------------------------------
freetype with bindings. harfbuzz without bindings
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
.freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 }
Sure. It looks to be the same. ``` using bindings of both freetype and harfbuzz .harfbuzz.buffer.GlyphInfo{ .codepoint = 65, .cluster = 2147484224 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 10, .cluster = 2 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 7, .cluster = 1620 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 2147484179, .cluster = 8 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 18, .cluster = 16777223 } .harfbuzz.buffer.GlyphInfo{ .codepoint = 1729, .cluster = 2147484291 } ------------------------------ freetype and harfbuzz without bindings .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c118c, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1190 } ------------------------------ freetype with bindings. harfbuzz without bindings .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 65, .mask = 2147484224, .cluster = 10, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1620, .mask = 2147484179, .cluster = 8, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1729, .mask = 2147484291, .cluster = 6, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1735, .mask = 2147484291, .cluster = 4, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 1815, .mask = 2147484192, .cluster = 2, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } .freetype.c.cimport:1:20.struct_hb_glyph_info_t{ .codepoint = 55, .mask = 2147484224, .cluster = 0, .var1 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1144, .var2 = .freetype.c.cimport:1:20.union__hb_var_int_t@7ffc052c1148 } ```
alichraghi commented 2022-07-18 18:15:15 +00:00 (Migrated from github.com)
Copy link

i believe #418 can fix this. but as a workaround you can test it yourself because i don't have a codebase for testing (this is an issue)

i believe #418 can fix this. but as a workaround you can test it yourself because i don't have a codebase for testing (this is an issue)
ghost commented 2022-07-19 04:37:40 +00:00 (Migrated from github.com)
Copy link

Hey Ali. Unfortunately the issue hasn't been fixed. The length wasn't the problem. I looked into it today and it seems the values of the codepoint, mask, and cluster are getting mixed together. I was able to solve it by changing the GlyphInfo struct members to

    codepoint: u32,
    mask: u32,
    cluster: u32,
    var1: u32,
    var2: u32,

Adding mask, var1 and var2 makes the size of GlyphInfo the same as hb_glyph_info_t. and results in correct values.

Hey Ali. Unfortunately the issue hasn't been fixed. The length wasn't the problem. I looked into it today and it seems the values of the *codepoint*, *mask*, and *cluster* are getting mixed together. I was able to solve it by changing the *GlyphInfo* struct members to ```zig codepoint: u32, mask: u32, cluster: u32, var1: u32, var2: u32, ``` Adding *mask*, *var1* and *var2* makes the size of *GlyphInfo* the same as *hb_glyph_info_t*. and results in correct values.
alichraghi commented 2022-07-19 05:06:46 +00:00 (Migrated from github.com)
Copy link

thanks for the solution

thanks for the solution
ghost commented 2022-07-19 05:18:26 +00:00 (Migrated from github.com)
Copy link

Happy to help. And thanks for the bindings, they've been very helpful.

Happy to help. And thanks for the bindings, they've been very helpful.
❤️ 1
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
sg/entrypoint
wrench/update-zig
sg/module-system-v2
sg/linux-stub
0.4
core-api
sysmidi
sg/perspective
v0.4.0
v0.3.0
v0.2.0
v0.1
Labels
Clear labels   
CI

   
all

   
basisu

   
blog

   
bug

Something isn't working

  
build

   
contributor-friendly

Good issue for contributors to take on

  
core

   
correctness

   
deferred

   
dev

   
direct3d-headers

   
docs

Improvements or additions to documentation

  
driver-os-issue

Issues that are very likely to be graphics driver / OS configuration issues

  
duplicate

This issue or pull request already exists

  
dxcompiler

   
editor

Graphical editor and Mach CLI

  
examples

   
experiment

   
feature-idea

New feature or request

  
feedback

   
flac

   
freetype

   
gamemode

   
gkurve

   
glfw

   
gpu

   
gpu-dawn

   
harfbuzz

   
help welcome

   
in-progress

   
infrastructure

   
invalid

This doesn't seem right

  
libmach

   
linux-audio-headers

   
long-term

   
mach

   
mach.gfx

   
mach.math

   
mach.physics

   
mach.testing

   
model3d

   
needs-triage

Issues that need triaging

  
object

object system

  
opengl-headers

   
opus

   
os/linux

   
os/macos

   
os/wasm

WebAssembly support

  
os/windows

   
package-manager

   
priority

   
proposal

   
proposal-accepted

   
question

Further information is requested

  
roadmap

   
slipped

   
stability

   
sysaudio

   
sysgpu

   
sysjs

   
validating-fix

   
vulkan-zig-generated

   
wayland-headers

   
website

   
wontfix

This will not be worked on

  
wrench

   
www

   
x11-headers

   
xcode-frameworks

   
zig-update
No labels
CI
all
basisu
blog
bug
build
contributor-friendly
core
correctness
deferred
dev
direct3d-headers
docs
driver-os-issue
duplicate
dxcompiler
editor
examples
experiment
feature-idea
feedback
flac
freetype
gamemode
gkurve
glfw
gpu
gpu-dawn
harfbuzz
help welcome
in-progress
infrastructure
invalid
libmach
linux-audio-headers
long-term
mach
mach.gfx
mach.math
mach.physics
mach.testing
model3d
needs-triage
object
opengl-headers
opus
os/linux
os/macos
os/wasm
os/windows
package-manager
priority
proposal
proposal-accepted
question
roadmap
slipped
stability
sysaudio
sysgpu
sysjs
validating-fix
vulkan-zig-generated
wayland-headers
website
wontfix
wrench
www
x11-headers
xcode-frameworks
zig-update
Milestone
Clear milestone
No items
No milestone
Mach 0.2
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach#415
No description provided.