mach: continues rendering after error #510

New issue

Closed

opened 2022-09-02 12:36:25 +00:00 by alichraghi · 1 comment

alichraghi commented

2022-09-02 12:36:25 +00:00

(Migrated from github.com)

error: Gamemode error error.RequestFailed -> dlopen failed - libgamemode.so: cannot open shared object file: No such file or directory
Warning: vkCreateInstance: Found no drivers!
Error: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/VulkanError.cpp:88)
    at CreateVkInstance (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:387)
    at Initialize (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:273)
    at Create (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:203)
    at operator() (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:462)

mach: found Null backend on CPU adapter: Null backend,
info: Frame 60
info: Frame 120
info: Frame 180
info: Frame 240
...

must be exited with error code 1 but instead ignores error and renders a black window

``` error: Gamemode error error.RequestFailed -> dlopen failed - libgamemode.so: cannot open shared object file: No such file or directory Warning: vkCreateInstance: Found no drivers! Error: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER at CheckVkSuccessImpl (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/VulkanError.cpp:88) at CreateVkInstance (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:387) at Initialize (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:273) at Create (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:203) at operator() (/home/runner/work/mach-gpu-dawn/mach-gpu-dawn/libs/dawn/src/dawn/native/vulkan/BackendVk.cpp:462) mach: found Null backend on CPU adapter: Null backend, info: Frame 60 info: Frame 120 info: Frame 180 info: Frame 240 ... ``` must be exited with error code `1` but instead ignores error and renders a black window

emidoots commented

2022-09-02 18:33:46 +00:00

(Migrated from github.com)

The reason this happens is because Dawn (rightfully) falls back to other backends as best it can. But because we include null backend, it falls back to that.

We should check if props.backend_type == .nul here: github.com/hexops/mach@b7ea4aeb89/src/platform/native.zig (L107)

The reason this happens is because Dawn (rightfully) falls back to other backends as best it can. But because we include null backend, it falls back to that. We should check if `props.backend_type == .nul` here: https://github.com/hexops/mach/blob/b7ea4aeb89064415ed1b43e851ae697fe0de480d/src/platform/native.zig#L107

👍 1