Correct to SemanticVersion #815

Closed

LaPingvino wants to merge 1 commit from semantic-version into main

LaPingvino commented

2023-06-21 18:08:23 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

- [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

rsepassi commented

2023-06-21 23:10:39 +00:00

(Migrated from github.com)

nit: for the "max" fields, probably want .patch = std.math.maxInt(u32)

nit: for the "max" fields, probably want `.patch = std.math.maxInt(u32)`

LaPingvino commented

2023-06-21 23:13:08 +00:00

(Migrated from github.com)

I just did a quick search and replace to make it work xD maybe send a replacement PR?

On June 21, 2023 at 23:10 GMT, Ryan Sepassi @.***> wrote:

nit: for the "max" fields, probably want .patch = std.math.maxInt(u32)

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>

I just did a quick search and replace to make it work xD maybe send a replacement PR? On June 21, 2023 at 23:10 GMT, Ryan Sepassi ***@***.***> wrote: nit: for the "max" fields, probably want .patch = std.math.maxInt(u32) — Reply to this email directly, [view it on GitHub](https://github.com/hexops/mach/pull/815#issuecomment-1601806943), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AAACQNWPIPIJSEW2XUGJMRLXMN5PTANCNFSM6AAAAAAZPDU2FE). You are receiving this because you authored the thread.Message ID: ***@***.***>

emidoots commented

2023-06-25 07:18:25 +00:00

(Migrated from github.com)

github.com/hexops/mach@c62bae6edc

https://github.com/hexops/mach/commit/c62bae6edcf00322d5b2b87bb5c72985813016a5