harfbuzz: GlyphPosition is missing a private field #993

New issue

Closed

opened 2023-08-22 21:33:46 +00:00 by dcov · 5 comments

dcov commented

2023-08-22 21:33:46 +00:00

(Migrated from github.com)

This was mentioned in the discord by someone else, it's missing the var field: github.com/harfbuzz/harfbuzz@970d2c438f/src/hb-buffer.h (L191)

It's a one line fix, which I can easily do, or whatever is easiest for you.

This was mentioned in the discord by someone else, it's missing the `var` field: https://github.com/harfbuzz/harfbuzz/blob/970d2c438f849700b879d76e8c183c2edfbaccdb/src/hb-buffer.h#L191 It's a one line fix, which I can easily do, or whatever is easiest for you.

emidoots commented

2023-08-23 05:35:52 +00:00

(Migrated from github.com)

Thanks for filing this @dcov ! Would you mind sending a PR? Otherwise I'll try to get to it soon

emidoots commented

2023-08-23 21:15:24 +00:00

(Migrated from github.com)

Fixed by https://github.com/hexops/mach-freetype/pull/22

dcov commented

2023-08-23 21:59:02 +00:00

(Migrated from github.com)

I should've checked back sooner haha sorry.

For future reference, I should file PRs under the specific repo right? So this one would've been under the mach-freetype repo correct?

@slimsag

I should've checked back sooner haha sorry. For future reference, I should file PRs under the specific repo right? So this one would've been under the `mach-freetype` repo correct? @slimsag

alichraghi commented

2023-08-23 22:33:59 +00:00

(Migrated from github.com)

yes. mach doesn't follow monorepo strategy anymore

emidoots commented

2023-08-23 22:38:16 +00:00

(Migrated from github.com)

Not sure what you mean?

PRs are sent to whatever repository the code exists in (you literally can't send them anywhere else, the code only exists in one place)

Issues are filed here in this repository (there's nowhere else to file them, so it should be very difficult to get confused here)

Hope that helps :)

Not sure what you mean? PRs are sent to whatever repository the code exists in (you literally can't send them anywhere else, the code only exists in one place) Issues are filed here in this repository (there's nowhere else to file them, so it should be very difficult to get confused here) Hope that helps :)