mach: exit if no backend found for adapter, add triangle-msaa example #513

Merged

alichraghi merged 3 commits from adapter into main

2022-09-08 04:25:36 +00:00

alichraghi commented

2022-09-03 09:20:23 +00:00

(Migrated from github.com)

Closes #510, #461

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Closes #510, #461 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

emidoots commented

2022-09-07 03:52:06 +00:00

(Migrated from github.com)

This PR is too big, can you break it up?

In specific it'd be nice to have one for:

triangle-msaa (without FPS in title)
one for "fps in window title"
exit if no backend found for adapter, plus the other small changes

The reason I'm asking this is specifically because I'm okay with changes 1 and 3, but have some concerns about how 2 has been implemented.

This PR is too big, can you break it up? In specific it'd be nice to have one for: 1. triangle-msaa (without FPS in title) 2. one for "fps in window title" 3. exit if no backend found for adapter, plus the other small changes The reason I'm asking this is specifically because I'm okay with changes 1 and 3, but have some concerns about how 2 has been implemented.

alichraghi commented

2022-09-07 10:13:20 +00:00

(Migrated from github.com)

removed 2. i hope there will be no need to create a seperate PR for 3 anymore 😅

removed `2`. i hope there will be no need to create a seperate PR for `3` anymore 😅

emidoots (Migrated from github.com) approved these changes

2022-09-08 04:25:31 +00:00