Call sysgpu device tick #1289

Merged
ronald-mz merged 3 commits from call_sysgpu_device_tick into main 2024-10-21 04:40:03 +00:00
ronald-mz commented 2024-10-21 04:22:03 +00:00 (Migrated from github.com)
  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Fixes: https://github.com/hexops/mach/issues/1288

Related to:
https://github.com/hexops/mach/issues/1232
https://github.com/hexops/mach/issues/1252
https://github.com/hexops/mach/issues/1253
https://github.com/hexops/mach/issues/1259
https://github.com/hexops/mach/issues/1270
https://github.com/hexops/mach/issues/1271
https://github.com/hexops/mach/issues/1275

Changes

  1. add: deviceTick call after platform update.
  2. add: display name to error.FailedToConnectToDisplay message.
  3. fix: double free during X11 deinit.
- [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right. Fixes: https://github.com/hexops/mach/issues/1288 Related to: https://github.com/hexops/mach/issues/1232 https://github.com/hexops/mach/issues/1252 https://github.com/hexops/mach/issues/1253 https://github.com/hexops/mach/issues/1259 https://github.com/hexops/mach/issues/1270 https://github.com/hexops/mach/issues/1271 https://github.com/hexops/mach/issues/1275 ## Changes 1. add: deviceTick call after platform update. 2. add: display name to `error.FailedToConnectToDisplay` message. 3. fix: double free during X11 deinit.
ronald-mz (Migrated from github.com) reviewed 2024-10-21 04:22:42 +00:00
@ -611,6 +611,7 @@ fn presentFrame(core: *Mod, entities: *mach.Entities.Mod) !void {
if (num_windows > 1) @panic("mach: Core currently only supports a single window");
_ = try state.platform.update();
mach.sysgpu.Impl.deviceTick(state.device);
ronald-mz (Migrated from github.com) commented 2024-10-21 04:22:42 +00:00

Rather than putting the tick in every device update, I thought it better to put it somewhere more general.

Rather than putting the tick in every device update, I thought it better to put it somewhere more general.
emidoots (Migrated from github.com) approved these changes 2024-10-21 04:39:44 +00:00
emidoots (Migrated from github.com) reviewed 2024-10-21 04:39:53 +00:00
@ -611,6 +611,7 @@ fn presentFrame(core: *Mod, entities: *mach.Entities.Mod) !void {
if (num_windows > 1) @panic("mach: Core currently only supports a single window");
_ = try state.platform.update();
mach.sysgpu.Impl.deviceTick(state.device);
emidoots (Migrated from github.com) commented 2024-10-21 04:39:53 +00:00

seems reasonable for now

seems reasonable for now
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!1289
No description provided.