Fix for vulkan sysgpu backend when only some attachments are cleared #1339

Open

platypro wants to merge 3 commits from platypro/vulkan-clear-fix into main

platypro commented

2025-01-27 03:34:57 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Fix for issue I ran into when I tried to "load" a color attachment, but "clear" the depth attachment. I got a validation error saying that all buffers must be represented in p_clear_values/clear_value_count so the driver can just jump to find the matching attachment. - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

emidoots commented

2025-02-02 04:00:47 +00:00

(Migrated from github.com)

Thanks for sending this, I need to check if this alters the behavior of any examples we have - not sure the underlying intention of this logic before

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin platypro/vulkan-clear-fix:platypro/vulkan-clear-fix

git switch platypro/vulkan-clear-fix

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff platypro/vulkan-clear-fix

git switch platypro/vulkan-clear-fix

git rebase main

git switch main

git merge --ff-only platypro/vulkan-clear-fix

git switch platypro/vulkan-clear-fix

git rebase main

git switch main

git merge --no-ff platypro/vulkan-clear-fix

git switch main

git merge --squash platypro/vulkan-clear-fix