Fix a case where a slice in the shader compiler points to undefined memory, causing a panic. #1350

Open

msg-programs wants to merge 1 commit from msg-programs/fix-bad-structconst-gen into main

msg-programs commented

2025-02-21 18:14:21 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

See issue #1343 for details. This fix can likely be improved, creating a slice for ever struct member just to access one of them in a loop seems suboptimal (L 2545).

- [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right. See issue #1343 for details. This fix can likely be improved, creating a slice for ever struct member just to access one of them in a loop seems suboptimal (L 2545).

This pull request is broken due to missing fork information.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin msg-programs/fix-bad-structconst-gen:msg-programs/fix-bad-structconst-gen

git switch msg-programs/fix-bad-structconst-gen

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff msg-programs/fix-bad-structconst-gen

git switch msg-programs/fix-bad-structconst-gen

git rebase main

git switch main

git merge --ff-only msg-programs/fix-bad-structconst-gen

git switch msg-programs/fix-bad-structconst-gen

git rebase main

git switch main

git merge --no-ff msg-programs/fix-bad-structconst-gen

git switch main

git merge --squash msg-programs/fix-bad-structconst-gen