Fix mult quarternion bug #1435

Open
mororo250 wants to merge 1 commit from mororo250/main into main
mororo250 commented 2025-11-08 00:04:48 +00:00 (Migrated from github.com)

There was a bug in the mulQuat multiplication
We were doing:
vz + uv_z * w2 + (qz * uv_y - qy * uv_x) * 2 instead of vz + uv_z * w2 + (qx * uv_y - qy * uv_x) * 2

I also optimized the function to use SIMD vectorized methods.

There was a bug in the mulQuat multiplication We were doing: vz + uv_z * w2 + (**qz** * uv_y - qy * uv_x) * 2 instead of vz + uv_z * w2 + (**qx** * uv_y - qy * uv_x) * 2 I also optimized the function to use SIMD vectorized methods.
This pull request is broken due to missing fork information.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin mororo250/main:mororo250/main
git switch mororo250/main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff mororo250/main
git switch mororo250/main
git rebase main
git switch main
git merge --ff-only mororo250/main
git switch mororo250/main
git rebase main
git switch main
git merge --no-ff mororo250/main
git switch main
git merge --squash mororo250/main
git switch main
git merge --ff-only mororo250/main
git switch main
git merge mororo250/main
git push origin main
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!1435
No description provided.