glfw: Clarify unreachable #161

Merged
leecannon merged 2 commits from clarify_unreachable into main 2022-02-11 22:09:09 +00:00
leecannon commented 2022-02-09 21:56:39 +00:00 (Migrated from github.com)

Sorry about those regressions 🤦

However one of them is not unreachable, glfwGetMonitors can return null for either an error or no monitors, i just botched the syntax for returning an empty slice.

This PR also documents all of the unreachable's with their justifications.

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Sorry about those regressions :facepalm: However one of them is not `unreachable`, `glfwGetMonitors` can return null for either an error or no monitors, i just botched the syntax for returning an empty slice. This PR also documents all of the `unreachable`'s with their justifications. - [X] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) approved these changes 2022-02-11 22:08:59 +00:00
emidoots (Migrated from github.com) left a comment

Thanks a ton! And no worries :)

Thanks a ton! And no worries :)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!161
No description provided.