build: remove intermediate static lib #24

Merged

mattnite merged 1 commit from link-simplify into main

2021-09-06 01:49:45 +00:00

mattnite commented

2021-08-30 03:56:20 +00:00

(Migrated from github.com)

[ x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Hey! I ran into linking issues when incorporating this into a project because the engine lib was picking up my own src/main.zig, I don't think this intermediate static lib is actually needed (at least on linux) so adding source directly to the step should do. (fingers crossed on that CI)

- [ x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right. Hey! I ran into linking issues when incorporating this into a project because the engine lib was picking up my own `src/main.zig`, I don't think this intermediate static lib is actually needed (at least on linux) so adding source directly to the step should do. (fingers crossed on that CI)

emidoots commented

2021-09-06 01:49:22 +00:00

(Migrated from github.com)

You rock @mattnite :) This looks great and makes sense.

It seems addStaticLibrary is not relative to build.zig, same issue we've run into with adding C sources (the reason we make those paths absolute / relative to build.zig first.) I guess we could keep the static lib, which might help with compile times in the future, if we did the same thing with making the src/main.zig include relative to our build.zig.

For now, though, this seems good enough! @Avokadoen I suspect this is the same issue you were experiencing when you sent #23 so maybe you can switch back to upstream soon :)

You rock @mattnite :) This looks great and makes sense. It seems `addStaticLibrary` is not relative to build.zig, same issue we've run into with adding C sources (the reason we make those paths absolute / relative to build.zig first.) I guess we could keep the static lib, which might help with compile times in the future, if we did the same thing with making the `src/main.zig` include relative to our build.zig. For now, though, this seems good enough! @Avokadoen I suspect this is the same issue you were experiencing when you sent #23 so maybe you can switch back to upstream soon :)

🎉 1

Avokadoen commented

2021-09-06 07:28:42 +00:00

(Migrated from github.com)

Good job @mattnite and @slimsag! 😄