{mach,gpu}: Fix store_op and publicize App.Funcs #255

Closed
silversquirl wants to merge 2 commits from main into main
silversquirl commented 2022-04-27 12:54:38 +00:00 (Migrated from github.com)

Sorry for not separating this into two PRs, they're very small changes and I couldn't be bothered :)

  • I forgot to make App.Funcs public when I created it
  • There was a typo in NativeInstance.beginRenderPass that caused store_op to use the value of load_op instead

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Sorry for not separating this into two PRs, they're very small changes and I couldn't be bothered :) - I forgot to make App.Funcs public when I created it - There was a typo in NativeInstance.beginRenderPass that caused `store_op` to use the value of `load_op` instead --- - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
iddev5 commented 2022-04-29 05:51:10 +00:00 (Migrated from github.com)

With the new application interface discussed on matrix and partially implemented with #257, the first change is no longer needed.

With the new application interface discussed on matrix and partially implemented with #257, the first change is no longer needed.
emidoots (Migrated from github.com) approved these changes 2022-04-29 20:10:22 +00:00
emidoots commented 2022-04-29 20:10:52 +00:00 (Migrated from github.com)

Thanks for the fix! I've merged the second change via cherry-pick and dropped the first one per #257

Thanks for the fix! I've merged the second change via cherry-pick and dropped the first one per #257

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!255
No description provided.