all: Update to latest Zig master (0.10.0-dev.2017+a0a2ce92c) #261

Merged

leecannon merged 4 commits from zig-master into main

2022-05-01 18:44:28 +00:00

leecannon commented

2022-04-30 16:53:58 +00:00

(Migrated from github.com)

std.math.ceil has been removed github.com/ziglang/zig@41dd2beaac
std.ChildProcess.init does not allocate anymore github.com/ziglang/zig@a0a2ce92ca
By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

- `std.math.ceil` has been removed https://github.com/ziglang/zig/commit/41dd2beaacade94c5c98400a4a655aea07b9e2f3 - `std.ChildProcess.init` does not allocate anymore https://github.com/ziglang/zig/commit/a0a2ce92ca129d28e22c63f7bace1672c43776b5 - [X] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

iddev5 commented

2022-04-30 17:35:03 +00:00

(Migrated from github.com)

zigimg has not yet been updated from upstream
zig version has to be changed in CI for this change to work

1) zigimg has not yet been updated from upstream 2) zig version has to be changed in CI for this change to work

leecannon commented

2022-04-30 18:08:28 +00:00

(Migrated from github.com)

I've submitted a PR to zigimg: https://github.com/zigimg/zigimg/pull/67
Updated the CI

Maybe it's worth switching to https://github.com/marketplace/actions/setup-zig, easy as:

- uses: goto-bus-stop/setup-zig@v1
  with:
    version: master

1. I've submitted a PR to zigimg: https://github.com/zigimg/zigimg/pull/67 2. Updated the CI Maybe it's worth switching to https://github.com/marketplace/actions/setup-zig, easy as: ```yaml - uses: goto-bus-stop/setup-zig@v1 with: version: master ```

iddev5 commented

2022-04-30 18:11:10 +00:00

(Migrated from github.com)

I dont have any evidence, but I think pinning zig to a particular version was intentional.

iddev5 (Migrated from github.com) approved these changes

2022-04-30 18:11:34 +00:00

iddev5 commented

2022-04-30 18:19:34 +00:00

(Migrated from github.com)

CI fail reason: github.com/hexops/mach@68d1679931/.github/workflows/ci.yml (L60)

Hard coded values 🤦‍♂️

CI fail reason: https://github.com/hexops/mach/blob/68d167993145a9c1d5998129e2c37c02db2bac8a/.github/workflows/ci.yml#L60 Hard coded values :man_facepalming:

emidoots commented

2022-04-30 20:35:28 +00:00

(Migrated from github.com)

Do you mind doing a find+replace of 0.10.0-dev.1600+af844931b -> 0.10.0-dev.2017+a0a2ce92c across the entire repo? There are other subrepos that have their own GitHub action CI pipelines, and I need to keep them all in sync.

Will give https://github.com/zigimg/zigimg/pull/67 a day ish to land and then merge this so we don't break the examples (or if you want to update the submodule to point to your fork temporarily, that'd work too)

Do you mind doing a find+replace of `0.10.0-dev.1600+af844931b` -> `0.10.0-dev.2017+a0a2ce92c` across the entire repo? There are other subrepos that have their own GitHub action CI pipelines, and I need to keep them all in sync. Will give https://github.com/zigimg/zigimg/pull/67 a day ish to land and then merge this so we don't break the examples (or if you want to update the submodule to point to your fork temporarily, that'd work too)

leecannon commented

2022-04-30 20:38:28 +00:00

(Migrated from github.com)

Find replace done.

❤️ 1

emidoots commented

2022-05-01 18:43:31 +00:00

(Migrated from github.com)

Switched temporarily to a fork of zigimg until that PR is merged.

emidoots (Migrated from github.com) approved these changes

2022-05-01 18:43:43 +00:00

emidoots (Migrated from github.com) left a comment