examples/gkurve: initial commit for resizable_label #327

2022-06-04T08:29:10Z

PiergiorgioZagaria commented

2022-06-04 08:29:10 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

About the tessellator code, the tessellator.zig and data_structures come from https://github.com/fubark/cosmic, the tracy code from the zig compiler

- [X] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right. About the tessellator code, the tessellator.zig and data_structures come from https://github.com/fubark/cosmic, the tracy code from the zig compiler

emidoots (Migrated from github.com) reviewed

2022-06-05 20:40:36 +00:00

examples/gkurve/LICENSE.tesselator

					
				@ -0,0 +1 @@

				TODO: add license, the tesselator implementation comes from https://github.com/fubark/cosmic/blob/master/graphics/src/tessellator.zig

@fubark We're using your Cosmic tesselator implementation, and plan to continue doing so in the future. For now @PiergiorgioZagaria has extracted it from Cosmic so we can use it here, I'm curious how you'd feel about having this live in a separate repository/library proper?

(if that's just more work for you, no worries, just figured I'd ask!)

@fubark We're using your Cosmic tesselator implementation, and plan to continue doing so in the future. For now @PiergiorgioZagaria has extracted it from Cosmic so we can use it here, I'm curious how you'd feel about having this live in a separate repository/library proper? (if that's just more work for you, no worries, just figured I'd ask!)

emidoots commented

2022-06-05 20:41:32 +00:00

(Migrated from github.com)

This is super cool @PiergiorgioZagaria - I'm planning to review later in the week (probably in 2-3 days)

PiergiorgioZagaria commented

2022-06-05 20:48:36 +00:00

(Migrated from github.com)

Is it ok if I make small commits to the PR for removing some bugs I found?

emidoots commented

2022-06-05 20:50:04 +00:00

(Migrated from github.com)

Oh absolutely, push whatever improvements you like. I'll check them all out in a few days time.

emidoots (Migrated from github.com) approved these changes

2022-06-10 20:23:43 +00:00

emidoots (Migrated from github.com) left a comment

LGTM, there's definitely code cleanup I'd like to do here but it's fine - the solution looks great overall and I'm excited to have this.

Next up for me is (1) sorting out the ECS and (2) moving this logic into an ECS-backed solution

LGTM, there's definitely code cleanup I'd like to do here but it's fine - the solution looks great overall and I'm excited to have this. Next up for me is (1) sorting out the ECS and (2) moving this logic into an ECS-backed solution

Sign in to join this conversation.

No reviewers

emidoots