freetype: ~99% Core-API Coverage #333

2022-06-06T19:48:05Z

alichraghi commented

2022-06-06 19:48:05 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

- breaking structure changes
- optimazed examples
- more tests

sorry for too much changes in just one commit. i wasn't able to split them because i had to revert or amend commits while doing breaking structure changes

- [X] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right. ``` - breaking structure changes - optimazed examples - more tests ``` sorry for too much changes in just one commit. i wasn't able to split them because i had to revert or amend commits while doing breaking structure changes

emidoots (Migrated from github.com) approved these changes

2022-06-08 02:22:27 +00:00

emidoots (Migrated from github.com) left a comment

Incredible work @alichraghi !

emidoots (Migrated from github.com) reviewed

2022-06-08 02:23:21 +00:00

build.zig

					
				@ -42,3 +42,3 @@

				        .{ .name = "fractal-cube", .packages = &[_]Pkg{Packages.zmath} },

				        .{ .name = "gkurve", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg, freetype.pkg }, .std_platform_only = true },

				        .{ .name = "gkurve", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg, freetype.freetype_pkg }, .std_platform_only = true },

				        .{ .name = "textured-cube", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg } },

I wonder if freetype.pkg and freetype.harfbuzz_pkg are not better names? freetype.freetype_pkg seems a little repetitive.

In any case, we should update README example for how to use.

I wonder if `freetype.pkg` and `freetype.harfbuzz_pkg` are not better names? `freetype.freetype_pkg` seems a little repetitive. In any case, we should update README example for how to use.

alichraghi (Migrated from github.com) reviewed

2022-06-08 02:56:56 +00:00

build.zig

					
				@ -42,3 +42,3 @@

				        .{ .name = "fractal-cube", .packages = &[_]Pkg{Packages.zmath} },

				        .{ .name = "gkurve", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg, freetype.pkg }, .std_platform_only = true },

				        .{ .name = "gkurve", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg, freetype.freetype_pkg }, .std_platform_only = true },

				        .{ .name = "textured-cube", .packages = &[_]Pkg{ Packages.zmath, Packages.zigimg } },