glfw: upgrade to glfw@master, use a submodule for upstream sources #346

Merged
emidoots merged 16 commits from sg/glfw-upgrade into main 2022-06-12 00:39:25 +00:00
emidoots commented 2022-06-11 23:10:48 +00:00 (Migrated from github.com)

Supersedes hexops/mach#344

  • Upgrades us to glfw@master (previously we were on GLFW v3.3.6 with custom patches on top, which have since been merged upstream)
  • Updates all of our wrappers to the latest GLFW version (done by walking through the diff)
  • We now use a submodule for the upstream repository, https://github.com/hexops/glfw, which has the minimal set of GLFW C sources and Vulkan headers needed.

The new GLFW version has a wider range of standard OS cursors, the ability to detect Wayland/X11 at runtime(!!!), many Wayland improvements, and custom allocator support (I didn't implement this, but left TODOs for this - PRs welcome!)

@C-BJ Sorry this turned out to be a lot more involved than your PR, so I am sending a new one instead. I added you as a co-author on the commit so you get credit in the Git history for contributing still! Hope that's OK.

Fixes hexops/mach#343

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Supersedes hexops/mach#344 * Upgrades us to glfw@master (previously we were on GLFW v3.3.6 with custom patches on top, which [have since been merged upstream](https://github.com/hexops/mach/issues/95)) * Updates all of our wrappers to the latest GLFW version (done by walking through [the diff](https://github.com/hexops/glfw/commit/daa69f32e9a8ec20492b24d79b9243cb7ddf1aa8#)) * We now use a submodule for the upstream repository, https://github.com/hexops/glfw, which has the minimal set of GLFW C sources and Vulkan headers needed. The new GLFW version has a wider range of standard OS cursors, the ability to detect Wayland/X11 at runtime(!!!), many Wayland improvements, and custom allocator support (I didn't implement this, but left TODOs for this - PRs welcome!) @C-BJ Sorry this turned out to be a lot more involved than your PR, so I am sending a new one instead. I added you as a co-author on the commit so you get credit in the Git history for contributing still! Hope that's OK. Fixes hexops/mach#343 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!346
No description provided.