ecs: fixes for setCapacity() and appendUndefined() #348

Merged
dweiller merged 3 commits from ecs-fixes into main 2022-06-12 15:02:53 +00:00
dweiller commented 2022-06-12 14:49:30 +00:00 (Migrated from github.com)

Closes #341 and fixes two other bugs:

  • a bug with the alignment calculation in setCapacity() which arose when the initial offset has the correct alignment, leading to the padding equal to the column element size (as oppose to 0 padding)

  • an off-by-one error in appendUndefined().

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

Closes #341 and fixes two other bugs: - a bug with the alignment calculation in `setCapacity()` which arose when the initial offset has the correct alignment, leading to the padding equal to the column element size (as oppose to 0 padding) - an off-by-one error in `appendUndefined()`. - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) approved these changes 2022-06-12 15:01:05 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!348
No description provided.