glfw: fix segfault in getPhysicalDevicePresentationSupport #364

Merged
leopoldek merged 1 commit from main into main 2022-06-24 17:10:06 +00:00
leopoldek commented 2022-06-23 07:10:32 +00:00 (Migrated from github.com)

Fixed an issue in the GLFW bindings where getPhysicalDevicePresentationSupport in vulkan.zig would segfault due to dereferencing an opaque handle. Note that I'm using https://github.com/Snektron/vulkan-zig. It might be better to use anytype and check if it's an enum or not like done in createWindowSurface:
github.com/hexops/mach@fa5afee5bc/glfw/src/vulkan.zig (L246-L251)

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Fixed an issue in the GLFW bindings where `getPhysicalDevicePresentationSupport` in `vulkan.zig` would segfault due to dereferencing an opaque handle. Note that I'm using https://github.com/Snektron/vulkan-zig. It might be better to use anytype and check if it's an enum or not like done in `createWindowSurface`: https://github.com/hexops/mach/blob/fa5afee5bce4be815d7a69926bcdec54d26a4889/glfw/src/vulkan.zig#L246-L251 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) approved these changes 2022-06-24 17:09:48 +00:00
emidoots commented 2022-06-24 17:09:53 +00:00 (Migrated from github.com)

Thanks!

Thanks!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!364
No description provided.