gpu: store pointer to WorkDoneCallback in gpu.Queue #366

Merged
dweiller merged 1 commit from queue-footgun into main 2022-06-24 17:14:20 +00:00
dweiller commented 2022-06-23 10:57:46 +00:00 (Migrated from github.com)

This change removes a footgun where the queue used to submit with a callback must be valid when the callback is run. This change makes it clear (hopefully) to the user that the queue does not need to be valid, only the WorkDoneCallback does, when the callback gets run.

Helps hexops/mach#183

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
This change removes a footgun where the queue used to submit with a callback must be valid when the callback is run. This change makes it clear (hopefully) to the user that the queue does not need to be valid, only the `WorkDoneCallback` does, when the callback gets run. Helps hexops/mach#183 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) approved these changes 2022-06-24 17:13:37 +00:00
emidoots (Migrated from github.com) left a comment

Thanks for this, much appreciated!

Thanks for this, much appreciated!
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!366
No description provided.