audio: make buildSoundIo private and point package to ./main.zig #379

2022-06-29T19:38:31Z

alichraghi commented

2022-06-29 19:38:31 +00:00

(Migrated from github.com)

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

- [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

emidoots (Migrated from github.com) reviewed

2022-06-30 03:55:42 +00:00

audio/build.zig

					
				@ -4,16 +4,8 @@ const Builder = std.build.Builder;

				const soundio_path = thisDir() ++ "/upstream/soundio";

    .name = "audio",

I don't know if mach-audio is better, but glfw and freetype are not mach-glfw or mach-freetype so it seems clear to me this should just be audio for consistency sake. Open to changing them all though!

```suggestion .name = "audio", ``` I don't know if `mach-audio` is better, but `glfw` and `freetype` are not `mach-glfw` or `mach-freetype` so it seems clear to me this should just be `audio` for consistency sake. Open to changing them all though!

emidoots (Migrated from github.com) reviewed

2022-06-30 03:57:02 +00:00

audio/build.zig

I do think we should still take an options struct in this function parameter, just so we can add any options necessary in the future without breaking user's current use of audio.link(...). It should just be an empty Options struct for now, though.

I do think we should still take an options struct in this function parameter, just so we can add any options necessary in the future without breaking user's current use of `audio.link(...)`. It should just be an empty `Options` struct for now, though.

				`@ -4,16 +4,8 @@ const Builder = std.build.Builder;`
				`const soundio_path = thisDir() ++ "/upstream/soundio";`

 @ -17,3 +8,4 @@
     .source = .{ .path = thisDir() ++ "/main.zig" },
 };
 pub fn build(b: *Builder) void {

Rows
Columns

audio: make buildSoundIo private and point package to ./main.zig #379

audio: make `buildSoundIo` private and point package to `./main.zig` #379