{mach, glfw}: Fix broken build due to using u32 inplace of i32 #398

Merged
iddev5 merged 2 commits from ay-fix-winpos into main 2022-07-09 22:07:55 +00:00
iddev5 commented 2022-07-09 07:57:08 +00:00 (Migrated from github.com)

This regression was introduced with github.com/hexops/mach@04013379db and also partially reverts github.com/hexops/mach@d3feaed383

Instead of doing the intCast, the other way to solve the problem is this suggestion: https://github.com/hexops/mach/pull/393#issuecomment-1178655298 (which is to use i32 for pos instead of i64), if it is an accepted solution.


  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
This regression was introduced with https://github.com/hexops/mach/commit/04013379db7fe2d1d33e54792647c933435bb30f and also partially reverts https://github.com/hexops/mach/commit/d3feaed383f9a7f8f8d5fa4d9e1d496ea7fbebc5 Instead of doing the intCast, the other way to solve the problem is this suggestion: https://github.com/hexops/mach/pull/393#issuecomment-1178655298 (which is to use i32 for pos instead of i64), if it is an accepted solution. --- - [X] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
alichraghi (Migrated from github.com) approved these changes 2022-07-09 09:00:06 +00:00
emidoots (Migrated from github.com) approved these changes 2022-07-09 22:07:50 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!398
No description provided.