hexops/mach

examples: add image-blur example #410

Merged

lucasromanosantos merged 1 commit from image-blur into main

2022-07-15 19:02:17 +00:00

lucasromanosantos commented

2022-07-13 21:30:46 +00:00

(Migrated from github.com)

hey! this is my first zig thing so feel free to provide the most feedback you can.

filter_size, iterations and block_dimension are hardcoded for now as the UI is being developed.

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

hey! this is my first zig thing so feel free to provide the most feedback you can. `filter_size`, `iterations` and `block_dimension` are hardcoded for now as the UI is being developed. - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

emidoots (Migrated from github.com) reviewed

2022-07-15 04:58:05 +00:00

examples/image-blur/main.zig

					
				@ -0,0 +1,290 @@

				const std = @import("std");

        .label = "blur shader",

```suggestion .label = "blur shader", ```

emidoots (Migrated from github.com) reviewed

2022-07-15 04:58:25 +00:00

examples/image-blur/main.zig

					
				@ -0,0 +1,290 @@

				const std = @import("std");

        .label = "fullscreen quad vertex shader",

```suggestion .label = "fullscreen quad vertex shader", ```

emidoots (Migrated from github.com) reviewed

2022-07-15 04:58:33 +00:00

examples/image-blur/main.zig

					
				@ -0,0 +1,290 @@

				const std = @import("std");

        .label = "fullscreen quad fragment shader",

```suggestion .label = "fullscreen quad fragment shader", ```

emidoots (Migrated from github.com) reviewed

2022-07-15 05:05:49 +00:00

examples/image-blur/main.zig

					
				@ -0,0 +1,290 @@

				const std = @import("std");

Change this to for (textures) |_, i| {, then it's not possible to work on the wrong amount of items.

Change this to `for (textures) |_, i| {`, then it's not possible to work on the wrong amount of items.

emidoots (Migrated from github.com) reviewed

2022-07-15 05:05:56 +00:00

examples/image-blur/main.zig

					
				@ -0,0 +1,290 @@

				const std = @import("std");

same here

same here

emidoots commented

2022-07-15 05:19:49 +00:00

(Migrated from github.com)

Actually the quality here looks great aside from the few suggestions I left. This is awesome, nice work!

Actually the quality here looks great aside from the few suggestions I left. This is awesome, nice work!

lucasromanosantos commented

2022-07-15 16:17:29 +00:00

(Migrated from github.com)

Done! Thanks @slimsag 😄

Done! Thanks @slimsag 😄

emidoots (Migrated from github.com) approved these changes

2022-07-15 19:01:28 +00:00

emidoots commented

2022-07-15 19:02:06 +00:00

(Migrated from github.com)

Nice work! This is cool :)

Alright if I add you to the contributors list at https://machengine.org/gpu/ as well?

Nice work! This is cool :) Alright if I add you to the contributors list at https://machengine.org/gpu/ as well?

lucasromanosantos commented

2022-07-15 20:56:59 +00:00

(Migrated from github.com)

Sure! I still have a lot to learn but looking forward to contribute more 🙂
Thanks again @slimsag

Sure! I still have a lot to learn but looking forward to contribute more 🙂 Thanks again @slimsag

Sign in to join this conversation.

No reviewers

No labels

contributor-friendly

direct3d-headers

driver-os-issue

linux-audio-headers

package-manager

proposal-accepted

vulkan-zig-generated

wayland-headers

xcode-frameworks

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

hexops/mach!410

No description provided.