all: use refAllDeclsRecursive to find and fix mistakes #425

Merged

alichraghi merged 5 commits from main into main

2022-07-21 01:55:59 +00:00

alichraghi commented

2022-07-20 17:08:40 +00:00

(Migrated from github.com)

sysjs tests still fails with lld errors, because js functions aren't linked. cc @iddev5 may have a fix for this

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

sysjs tests still fails with lld errors, because js functions aren't linked. cc @iddev5 may have a fix for this - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

iddev5 commented

2022-07-20 18:09:50 +00:00

(Migrated from github.com)

Sysjs cant be tested normally because its a wasm application. My suggestion is to just remove it from testing for now. Actually we need to design a different kind of test runner specifically for wasm, which is quite a lot of work on its own and is out of scope of this PR.

iddev5 commented

2022-07-20 18:11:32 +00:00

(Migrated from github.com)

Good catch on sysjs integer type mistakes, not sure why it never appeared on me.

emidoots (Migrated from github.com) approved these changes

2022-07-21 01:54:15 +00:00

emidoots commented

2022-07-21 01:55:50 +00:00

(Migrated from github.com)

FYI, all the CI is currently failing (on main too, not this branch) due to -Dtarget not being valid anymore with zig build test:

FYI, all the CI is currently failing (on main too, not this branch) due to `-Dtarget` not being valid anymore with `zig build test`: <img width="799" alt="image" src="https://user-images.githubusercontent.com/3173176/180112844-3a6f477c-17d8-4a37-ba2e-54409a17875d.png">

alichraghi commented

2022-07-21 07:09:44 +00:00

(Migrated from github.com)

oops, didn't know that was a thing