all: build: install tests exe #434

Merged
alichraghi merged 2 commits from main into main 2022-07-25 18:21:38 +00:00
alichraghi commented 2022-07-24 19:17:17 +00:00 (Migrated from github.com)

Closes #433

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Closes #433 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) reviewed 2022-07-25 01:43:42 +00:00
@ -25,3 +25,4 @@
main_tests.addPackage(gpu.pkg);
main_tests.addPackage(glfw.pkg);
main_tests.install();
emidoots (Migrated from github.com) commented 2022-07-25 01:43:42 +00:00

Is it actually right to install tests? This would place them in the zig-out directory as I understand it, which feels not ideal to me. For example, if we were to begin publishing binary releases I don't think we would want these included.

Is it actually right to _install_ tests? This would place them in the `zig-out` directory as I understand it, which feels not ideal to me. For example, if we were to begin publishing binary releases I don't think we would want these included.
emidoots (Migrated from github.com) approved these changes 2022-07-25 01:44:02 +00:00
emidoots (Migrated from github.com) left a comment

LGTM excluding the installation point

LGTM excluding the installation point
alichraghi (Migrated from github.com) reviewed 2022-07-25 08:23:28 +00:00
@ -25,3 +25,4 @@
main_tests.addPackage(gpu.pkg);
main_tests.addPackage(glfw.pkg);
main_tests.install();
alichraghi (Migrated from github.com) commented 2022-07-25 08:23:28 +00:00

i think we should just wait for zig to provide a way to compile without producing binaries

i think we should just wait for zig to provide a way to compile without producing binaries
emidoots (Migrated from github.com) approved these changes 2022-07-25 18:21:25 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!434
No description provided.