dev: add other workflows to ci-lint.sh #435

Merged
alichraghi merged 1 commit from main into main 2022-07-27 17:25:59 +00:00
alichraghi commented 2022-07-26 07:03:02 +00:00 (Migrated from github.com)

Fixes #432

  • By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
Fixes #432 - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.
emidoots (Migrated from github.com) reviewed 2022-07-27 03:07:45 +00:00
@ -1,4 +1,6 @@
#!/usr/bin/env bash
emidoots (Migrated from github.com) commented 2022-07-27 03:07:44 +00:00

Can we use a find command to find these files instead of manually listing them all out? Otherwise this will quickly become out of date

Can we use a `find` command to find these files instead of manually listing them all out? Otherwise this will quickly become out of date
emidoots (Migrated from github.com) reviewed 2022-07-27 03:09:29 +00:00
@ -1,4 +1,6 @@
#!/usr/bin/env bash
emidoots (Migrated from github.com) commented 2022-07-27 03:09:29 +00:00

Perhaps:

actionlint $(find . | grep -v '\.git/' | grep '\.github/workflows/' | grep '.yml')
Perhaps: ```sh actionlint $(find . | grep -v '\.git/' | grep '\.github/workflows/' | grep '.yml') ```
emidoots (Migrated from github.com) reviewed 2022-07-27 03:10:22 +00:00
@ -1,4 +1,6 @@
#!/usr/bin/env bash
emidoots (Migrated from github.com) commented 2022-07-27 03:10:21 +00:00

We should also change this script to use this at the top, so it fails if any commands in it fail, and so we always run from the repo root:

#!/usr/bin/env bash
set -exuo pipefail
cd "$(dirname "${BASH_SOURCE[0]}")"/..
We should also change this script to use this at the top, so it fails if any commands in it fail, and so we always run from the repo root: ``` #!/usr/bin/env bash set -exuo pipefail cd "$(dirname "${BASH_SOURCE[0]}")"/.. ```
emidoots (Migrated from github.com) approved these changes 2022-07-27 17:25:50 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hexops/mach!435
No description provided.