enumify: make all constants proper ziggified enums #56

Merged

emidoots merged 23 commits from sg/enumify into main

2021-10-31 03:06:03 +00:00

emidoots commented

2021-10-31 03:03:01 +00:00

(Migrated from github.com)

This makes all GLFW constants proper Zig enums, fixing hexops/mach#37

Also fixes some previously failing tests that were not included properly, and moves e.g. glfw.mod.Mod to glfw.Mod

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

This makes all GLFW constants proper Zig enums, fixing hexops/mach#37 Also fixes some previously failing tests that were not included properly, and moves e.g. `glfw.mod.Mod` to `glfw.Mod` - [x] By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

emidoots commented

2021-10-31 03:03:34 +00:00

(Migrated from github.com)

@Avokadoen FYI this is a fairly large change, things are much nicer now but depending on how extensive your usage is you may need to update a bit. Hope that's okay :)

👍 1

Avokadoen commented

2021-10-31 10:25:02 +00:00

(Migrated from github.com)

@slimsag Awesome work! 🥳
I'm still locked to my old fork for now. Having issue with vulkan in master branch. I haven't filed a issue since I am unsure exactly what is wrong, but it seems the upstream vulkan files and my system vulkan library is two different versions and it causes issues when i try to call glfw.createWindowSurface (get error -7). 🤔

@slimsag Awesome work! 🥳 I'm still locked to my old fork for now. Having issue with vulkan in master branch. I haven't filed a issue since I am unsure exactly what is wrong, but it _seems_ the upstream vulkan files and my system vulkan library is two different versions and it causes issues when i try to call ``glfw.createWindowSurface`` (get error -7). 🤔

emidoots commented

2021-10-31 18:53:30 +00:00

(Migrated from github.com)

@Avokadoen I'm not sure what -7 corresponds to, but you might be running into an issue I fixed just last night in github.com/hexops/mach@c16d6bf615

Also, I just published an example to confirm mach-glfw and vulkan-zig work well together, check it out: https://github.com/hexops/mach-glfw-vulkan-example

@Avokadoen I'm not sure what -7 corresponds to, but you might be running into an issue I fixed just last night in https://github.com/hexops/mach/commit/c16d6bf615df5403244ad93fc6f6ee2adc4f7bf3 Also, I just published an example to confirm mach-glfw and vulkan-zig work well together, check it out: https://github.com/hexops/mach-glfw-vulkan-example

Avokadoen commented

2021-10-31 21:59:27 +00:00

(Migrated from github.com)

Awesome, I'll try to update asap! 😍